From ff41c6555d66920190373e62c90d52493e003834 Mon Sep 17 00:00:00 2001 From: Max Date: Sat, 8 Nov 2025 16:26:46 +0800 Subject: [PATCH] Refactor CreateAssistant and UpdateAssistant response handling to return only assistant_id - Updated the CreateAssistant and UpdateAssistant functions to simplify the success response by returning only the assistant_id instead of the full assistant data. - Removed unnecessary JSON marshaling and unmarshaling, improving performance and clarity in response handling. --- openapi/agent/assistant.go | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/openapi/agent/assistant.go b/openapi/agent/assistant.go index 1f955576..04a87e97 100644 --- a/openapi/agent/assistant.go +++ b/openapi/agent/assistant.go @@ -1,7 +1,6 @@ package agent import ( - "encoding/json" "fmt" "strconv" "strings" @@ -391,8 +390,10 @@ func CreateAssistant(c *gin.Context) { log.Error("Error reloading assistant %s: %v", id, err) } - // Return success response - response.RespondWithSuccess(c, response.StatusOK, assistantData) + // Return success response with only assistant_id + response.RespondWithSuccess(c, response.StatusOK, map[string]interface{}{ + "assistant_id": id, + }) } // UpdateAssistant updates an existing assistant @@ -488,22 +489,16 @@ func UpdateAssistant(c *gin.Context) { } // Reload the assistant to ensure it's available in cache with updated data - updatedAssistant, err := assistant.Get(assistantID) + _, err = assistant.Get(assistantID) if err != nil { // Just log the error, don't fail the request log.Error("Error reloading assistant %s: %v", assistantID, err) - // Return simple success response - response.RespondWithSuccess(c, response.StatusOK, map[string]interface{}{"assistant_id": assistantID}) - return } - // Convert updated assistant to map for response - responseData, _ := json.Marshal(updatedAssistant) - var responseMap map[string]interface{} - json.Unmarshal(responseData, &responseMap) - - // Return success response with updated assistant data - response.RespondWithSuccess(c, response.StatusOK, responseMap) + // Return success response with only assistant_id + response.RespondWithSuccess(c, response.StatusOK, map[string]interface{}{ + "assistant_id": assistantID, + }) } // checkAssistantPermission checks if the user has permission to access the assistant