opencode/yao
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1204 from trheyi/main

Browse source 
Refactor OTP tests and cleanup code
This commit is contained in:
Max 2025-10-15 17:22:15 +08:00 • committed by GitHub
commit c0317354d6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
utils/otp/otp.go
View file

@ -119,4 +119,3 @@ func generateRandomString(length int, charset string) string {
return string(result)
}

15
utils/otp/otp_test.go
View file

@ -31,10 +31,10 @@ func TestGenerate(t *testing.T) {
option.Length = 8
_, alphaCode := Generate(option)
assert.Equal(t, 8, len(alphaCode), "Alphanumeric code should match length")
// Verify alphanumeric
for _, c := range alphaCode {
assert.True(t, (c >= 'A' && c <= 'Z') || (c >= '0' && c <= '9'),
assert.True(t, (c >= 'A' && c <= 'Z') || (c >= '0' && c <= '9'),
"Code should be alphanumeric uppercase")
}
t.Logf("Generated alphanumeric code: %s", alphaCode)
@ -175,11 +175,11 @@ func TestOTPZeroValues(t *testing.T) {
// Test with zero/empty option values
option := Option{}
id, code := Generate(option)
assert.NotEmpty(t, id, "Should generate ID even with zero values")
assert.NotEmpty(t, code, "Should generate code even with zero values")
assert.Equal(t, 6, len(code), "Should use default length")
// Should be numeric by default
for _, c := range code {
assert.True(t, c >= '0' && c <= '9', "Should default to numeric")
@ -189,11 +189,11 @@ func TestOTPZeroValues(t *testing.T) {
func TestOTPInvalidType(t *testing.T) {
option := NewOption()
option.Type = "invalid_type"
id, code := Generate(option)
assert.NotEmpty(t, id)
assert.NotEmpty(t, code)
// Should fallback to numeric
for _, c := range code {
assert.True(t, c >= '0' && c <= '9', "Invalid type should fallback to numeric")
@ -221,9 +221,8 @@ func BenchmarkGenerateAlphanumeric(b *testing.B) {
option := NewOption()
option.Type = "alphanumeric"
option.Length = 8
for i := 0; i < b.N; i++ {
Generate(option)
}
}