picoclaw/pkg/tools
shikihane c368b5b359
feat(feishu,tools): add outbound media delivery via send_file tool (#1156)
* feat(feishu): implement SendMedia and add send_file tool

Add outbound media support for the Feishu channel so the agent can send
images and files to users via the MediaStore pipeline.

Feishu channel:
- SendMedia dispatches media parts as image or file uploads
- sendImage uploads via Image.Create then sends image message
- sendFile uploads via File.Create then sends file message
- feishuFileType maps extensions to Feishu file_type values

send_file tool:
- New tool lets the LLM send a local file to the current chat
- Validates path, registers file in MediaStore, returns media ref
- Agent loop wires tool registration, MediaStore propagation, and
  context updates

Tested on Radxa Cubie A7A (arm64) with Feishu websocket channel.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(agent): publish outbound media regardless of SendResponse flag

The SendResponse flag controls whether the agent loop publishes the
final text response (callers that publish it themselves set this to
false). However, the media publish path was also gated behind this
flag, which meant tool-produced media was silently dropped for normal
channel messages.

Media should be published immediately when a tool returns media refs,
independent of how the text response is delivered.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(tools): use magic-bytes MIME detection and add file size limit to send_file

- Replace hardcoded extension-to-MIME map with h2non/filetype (magic
  bytes) + mime.TypeByExtension fallback, consistent with the vision
  pipeline in resolveMediaRefs
- Add configurable max file size check (defaults to config.DefaultMaxMediaSize,
  20 MB) to prevent oversized uploads
- Add tests for magic-bytes detection, extension fallback, size limit,
  and default max size

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* refactor(agent): add ForEachTool to AgentRegistry for cross-agent tool lookup

Extract the pattern of iterating agents to find a named tool into
AgentRegistry.ForEachTool, simplifying SetMediaStore propagation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(agent,tools): adapt send_file to ctx-based channel injection after upstream refactor

Replace ContextualTool interface (removed upstream) with direct ctx
reading in SendFileTool.Execute, using ToolChannel/ToolChatID helpers.
Remove updateToolContexts which is no longer needed since ExecuteWithContext
already injects channel/chatID into ctx for all tools.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* feat(tools): support toggling send_file tool via config

Add SendFileConfig with Enabled field to ToolsConfig, defaulting to
true. Wrap send_file tool registration in loop.go with the config
check, consistent with the pattern used by other tools.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-06 19:42:52 +08:00
..
base.go fix: eliminate data races on shared tool instances (#1080) 2026-03-05 09:57:33 +08:00
cron.go fix: eliminate data races on shared tool instances (#1080) 2026-03-05 09:57:33 +08:00
edit.go fix(tools): allow /dev/null redirection and add read/write sandbox split (#967) 2026-03-02 12:22:02 +08:00
edit_test.go fix(security): workspace sandbox avoid time-of-check/time-of-use (TOCTOU) races (#464) 2026-02-23 20:09:53 +11:00
filesystem.go fix(tools): allow /dev/null redirection and add read/write sandbox split (#967) 2026-03-02 12:22:02 +08:00
filesystem_test.go fix(tools): allow /dev/null redirection and add read/write sandbox split (#967) 2026-03-02 12:22:02 +08:00
i2c.go refactor: cleanup dead code and turn on dead code detection in CI (#515) 2026-02-24 21:52:25 +08:00
i2c_linux.go feat(linter): Fix govet linter 2026-02-20 22:35:16 +02:00
i2c_other.go feat(fmt): Run formatters 2026-02-18 21:48:23 +02:00
mcp_tool.go fix: improve MCP tool name collision safety and registry overwrite warning 2026-03-01 12:00:26 +08:00
mcp_tool_test.go chore: fix lint issues in mcp and agent packages 2026-03-01 08:53:13 +08:00
message.go fix: eliminate data races on shared tool instances (#1080) 2026-03-05 09:57:33 +08:00
message_test.go fix: eliminate data races on shared tool instances (#1080) 2026-03-05 09:57:33 +08:00
registry.go fix: eliminate data races on shared tool instances (#1080) 2026-03-05 09:57:33 +08:00
registry_test.go fix: eliminate data races on shared tool instances (#1080) 2026-03-05 09:57:33 +08:00
result.go feat(channels): add MediaSender optional interface for outbound media 2026-02-23 03:10:57 +08:00
result_test.go feat(fmt): Run formatters 2026-02-18 21:48:23 +02:00
send_file.go feat(feishu,tools): add outbound media delivery via send_file tool (#1156) 2026-03-06 19:42:52 +08:00
send_file_test.go feat(feishu,tools): add outbound media delivery via send_file tool (#1156) 2026-03-06 19:42:52 +08:00
shell.go refactor(tools): remove redundant kill -9 pattern 2026-03-06 18:34:46 +08:00
shell_process_unix.go fix(exec): terminate process tree on timeout 2026-02-18 02:01:29 +08:00
shell_process_windows.go fix(exec): terminate process tree on timeout 2026-02-18 02:01:29 +08:00
shell_test.go fix(exec): block kill command pattern in safety guard 2026-03-05 12:45:53 +08:00
shell_timeout_unix_test.go fix(exec) fail close on invalid deny pattern (#781) 2026-02-28 16:24:26 +08:00
skills_install.go refactor(pkg): move atomic file write to dedicated fileutil package 2026-02-24 23:57:13 +08:00
skills_install_test.go feat(fmt): Fix formatting 2026-02-20 20:03:11 +02:00
skills_search.go feat(fmt): Fix formatting 2026-02-20 20:03:11 +02:00
skills_search_test.go feat(fmt): Fix formatting 2026-02-20 20:03:11 +02:00
spawn.go fix: eliminate data races on shared tool instances (#1080) 2026-03-05 09:57:33 +08:00
spawn_test.go fix: reject empty task in spawn tool (#740) 2026-02-25 07:39:49 +11:00
spi.go refactor: cleanup dead code and turn on dead code detection in CI (#515) 2026-02-24 21:52:25 +08:00
spi_linux.go feat(fmt): Run formatters 2026-02-18 21:48:23 +02:00
spi_other.go feat(fmt): Run formatters 2026-02-18 21:48:23 +02:00
subagent.go fix: eliminate data races on shared tool instances (#1080) 2026-03-05 09:57:33 +08:00
subagent_tool_test.go fix: eliminate data races on shared tool instances (#1080) 2026-03-05 09:57:33 +08:00
toolloop.go feat: execute LLM tool calls in parallel for faster response (#1070) 2026-03-04 17:17:28 +08:00
types.go feat(fmt): Run formatters 2026-02-18 21:48:23 +02:00
web.go Merge upstream/main into feat/searxng 2026-03-04 21:42:03 +01:00
web_test.go feat(tools): add GLM Search (智谱) web search provider (#1057) 2026-03-04 14:58:12 +08:00