From a66fbbef0c1ea107a81e720d3a109e60c30aa894 Mon Sep 17 00:00:00 2001 From: Andy Lo-A-Foe Date: Tue, 28 Apr 2026 10:17:21 +0200 Subject: [PATCH] fix(mcp): close response body in headerTransport tests Fixes bodyclose linter warnings. Co-Authored-By: Claude Opus 4.6 --- pkg/mcp/manager_test.go | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/pkg/mcp/manager_test.go b/pkg/mcp/manager_test.go index e623f4f0c..79e91fb29 100644 --- a/pkg/mcp/manager_test.go +++ b/pkg/mcp/manager_test.go @@ -651,10 +651,11 @@ func TestHeaderTransport_DynamicHeaders(t *testing.T) { }) req, _ := http.NewRequestWithContext(ctx, http.MethodPost, "http://example.com", nil) - _, err := transport.RoundTrip(req) + resp, err := transport.RoundTrip(req) if err != nil { t.Fatalf("RoundTrip() error = %v", err) } + resp.Body.Close() if got := captured.Get("X-Static"); got != "from-config" { t.Errorf("X-Static = %q, want %q", got, "from-config") @@ -686,10 +687,11 @@ func TestHeaderTransport_DynamicOverridesStatic(t *testing.T) { }) req, _ := http.NewRequestWithContext(ctx, http.MethodPost, "http://example.com", nil) - _, err := transport.RoundTrip(req) + resp, err := transport.RoundTrip(req) if err != nil { t.Fatalf("RoundTrip() error = %v", err) } + resp.Body.Close() if got := captured.Get("Authorization"); got != "Bearer dynamic" { t.Errorf("Authorization = %q, want dynamic to override static %q", got, "Bearer dynamic") @@ -711,10 +713,11 @@ func TestHeaderTransport_NoDynamicHeaders(t *testing.T) { } req, _ := http.NewRequestWithContext(context.Background(), http.MethodPost, "http://example.com", nil) - _, err := transport.RoundTrip(req) + resp, err := transport.RoundTrip(req) if err != nil { t.Fatalf("RoundTrip() error = %v", err) } + resp.Body.Close() if got := captured.Get("X-Static"); got != "val" { t.Errorf("X-Static = %q, want %q", got, "val")